feat: Add S3 bucket owner enforcement #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
feature
Tyler-2
force-pushed
the
add-object-ownership-enforcement
branch
from
1a832d6 to
bd4cae8
Compare
Tyler-2
force-pushed
the
add-object-ownership-enforcement
branch
from
b3fc72a to
aef4591
Compare
| - C(BucketOwnerEnforced) - ACLs are disabled and no longer affect access permissions to your | ||
| bucket. Requests to set or update ACLs fail. However, requests to read ACLs are supported. | ||
| Bucket owner has full ownership and control. Object writer no longer has full ownership and | ||
| control. |
There was a problem hiding this comment.
Could you please add something like: C(BucketOwnerEnforced) has been added in amazon.aws version 3.2.0
| @@ -0,0 +1,2 @@ | |||
| minor_changes: | |||
| - s3_bucket - Add support for enforced bucket owner object ownership. | |||
There was a problem hiding this comment.
Suggested change
| - s3_bucket - Add support for enforced bucket owner object ownership. | |
| - s3_bucket - Add support for enforced bucket owner object ownership (https://github.com/ansible-collections/amazon.aws/pull/694). |
Signed-off-by: Alina Buzachis <[email protected]>
alinabuzachis
approved these changes
Mar 24, 2022
markuman
approved these changes
Mar 24, 2022
alinabuzachis
added
the
backport-3
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #735 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Mar 24, 2022
feat: Add S3 bucket owner enforcement
SUMMARY
AWS finally supports the ability to enforce object ownership such that the owner of the bucket owns all objects. This adds support for that.
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
s3_bucket
ADDITIONAL INFORMATION
---
- hosts: localhost
tasks:
- s3_bucket:
name: tyler-test-123
state: present
- s3_bucket:
name: tyler-test-123
object_ownership: BucketOwnerEnforced
state: present
- s3_bucket:
name: tyler-test-123
state: absent
- s3_bucket:
name: tyler-test-123
object_ownership: BucketOwnerEnforced
state: present
- s3_bucket:
name: tyler-test-123
state: absent
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <[email protected]>
(cherry picked from commit 7cf0e50)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Mar 24, 2022
[PR #694/7cf0e505 backport][stable-3] feat: Add S3 bucket owner enforcement This is a backport of PR #694 as merged into main (7cf0e50). SUMMARY AWS finally supports the ability to enforce object ownership such that the owner of the bucket owns all objects. This adds support for that. ISSUE TYPE Feature Pull Request COMPONENT NAME s3_bucket ADDITIONAL INFORMATION --- - hosts: localhost tasks: - s3_bucket: name: tyler-test-123 state: present - s3_bucket: name: tyler-test-123 object_ownership: BucketOwnerEnforced state: present - s3_bucket: name: tyler-test-123 state: absent - s3_bucket: name: tyler-test-123 object_ownership: BucketOwnerEnforced state: present - s3_bucket: name: tyler-test-123 state: absent
1 task
1 task
1 task
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…s3_sync-integration-test s3_sync: Integration test fix: empty buckets before deleting SUMMARY Added tasks to empty buckets before deleting them. S3 requires a bucket to be empty before it can be deleted. The integration tests in the s3_sync try to delete the buckets without emptying them. Fixes ansible-collections#694. ISSUE TYPE Bugfix Pull Request COMPONENT NAME tests/integration/targets/s3_sync Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Jill R <None> Reviewed-by: None <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
AWS finally supports the ability to enforce object ownership such that the owner of the bucket owns all objects. This adds support for that.
ISSUE TYPE
COMPONENT NAME
s3_bucket
ADDITIONAL INFORMATION